Modal close button on dark mode #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmolen
added
the
needs-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4950 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 760 760
Lines 25817 25818 +1
Branches 3382 3382
=======================================
+ Hits 24944 24945 +1
Misses 608 608
Partials 265 265 ☔ View full report in Codecov by Sentry. |
vaszig
approved these changes
Dec 18, 2024
sergei-maertens
approved these changes
Dec 18, 2024
The modal close button changes color based on the light/dark mode of the page. In addition, focus now increases the button opacity, making it more user-friendly
robinmolen
force-pushed
the
bug/4949-invisible-modal-button-on-dark-mode
branch
from
1456106 to
53dff87
Compare
sergei-maertens
deleted the
bug/4949-invisible-modal-button-on-dark-mode
branch
sergei-maertens
pushed a commit
that referenced
this pull request
Dec 18, 2024
The modal close button changes color based on the light/dark mode of the page. In addition, focus now increases the button opacity, making it more user-friendly Backport-of: #4950
sergei-maertens
pushed a commit
that referenced
this pull request
Dec 18, 2024
The modal close button changes color based on the light/dark mode of the page. In addition, focus now increases the button opacity, making it more user-friendly Backport-of: #4950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4949
Changes
The modal close button changes color based on the light/dark mode of the page.
In addition, focus now increases the button opacity, making it more visible and user-friendly
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene